Skip to content
This repository has been archived by the owner on Jun 21, 2022. It is now read-only.

PMM-5967 Bind-IP for agent listeners #394

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

PMM-5967 Bind-IP for agent listeners #394

wants to merge 15 commits into from

Conversation

pavhl
Copy link

@pavhl pavhl commented May 19, 2020

Related to: percona/pmm-agent#160

@it-percona
Copy link

it-percona commented May 19, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@pavhl pavhl mentioned this pull request May 19, 2020
Open
@codecov
Copy link

codecov bot commented May 20, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (PMM-2.0@9dfeddb). Click here to learn what that means.
The diff coverage is 55.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##             PMM-2.0     #394   +/-   ##
==========================================
  Coverage           ?   49.61%           
==========================================
  Files              ?       98           
  Lines              ?    11656           
  Branches           ?        0           
==========================================
  Hits               ?     5783           
  Misses             ?     5389           
  Partials           ?      484
Flag Coverage Δ
all 48.81% <55.28%> (?)
cover 49.69% <50.88%> (?)
crosscover 49.58% <55.28%> (?)
update 21.84% <4.96%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/pmm-managed-init/main.go 0.00% <0.00%> (ø)
cmd/pmm-managed-starlark/main.go 0.00% <0.00%> (ø)
main.go 0.00% <0.00%> (ø)
services/agents/grpc/agent_server.go 0.00% <0.00%> (ø)
services/agents/registry.go 0.00% <0.00%> (ø)
services/agents/roster.go 0.00% <0.00%> (ø)
services/inventory/agents.go 39.48% <ø> (ø)
services/inventory/grpc/agents_server.go 0.00% <ø> (ø)
services/inventory/grpc/nodes_server.go 0.00% <ø> (ø)
services/inventory/grpc/services_server.go 0.00% <ø> (ø)
... and 85 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dfeddb...8b1032d. Read the comment docs.

@BupycHuk
Copy link
Member

Hi @Crash129 thank you for your PR, but probably it should be done other way. We already have address of the node on backend side and it can be used from there..
We will discuss it with our PO and back to you. Thank you.

@AlekSi AlekSi removed their request for review February 17, 2021 08:33
@gosi-at
Copy link

gosi-at commented Oct 30, 2021

Has this been implemented?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BupycHuk BupycHuk Awaiting requested review from BupycHuk BupycHuk is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pavhl @it-percona @BupycHuk @gosi-at @AlekSi